Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monotoneViz: use xorg.* packages directly instead of xlibsWrapper ind… #205484

Merged
merged 1 commit into from
Dec 10, 2022
Merged

monotoneViz: use xorg.* packages directly instead of xlibsWrapper ind… #205484

merged 1 commit into from
Dec 10, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Dec 10, 2022 •
edited
Loading

…irection

Validated as no change in out output with diffoscope.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
monotoneViz: use xorg.* packages directly instead of xlibsWrapper ind…
15c3978 
…irection

Validated as no change in `out` output with `diffoscope`.
@trofi trofi mentioned this pull request Dec 10, 2022
Closed
83 tasks
@trofi
Copy link
Contributor Author

trofi commented Dec 10, 2022

Result of nixpkgs-review pr 205484 run on x86_64-linux 1

1 package built:
  • monotoneViz

@ofborg ofborg bot requested a review from 7c6f434c December 10, 2022 15:01
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 10, 2022
@7c6f434c 7c6f434c merged commit 60aa3fa into NixOS:master Dec 10, 2022
@trofi trofi deleted the monotoneViz-without-xlibsWrapper branch December 10, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trofi @7c6f434c